I have a relationship between two tables. The two tables PKs are int types.
In one table (UserS), I need to supply the Username and get the corresponding ID (which is the PK). This is the standard ASP.NET user table when using forms authentication.
However, in a related table, I want to supply the ID I find from the Users table to get a value out.
Run query to get ID for a username (simple select/where query) Return the result Run a subquery where I can pass in the above result - Get value where ID = result
運行查詢以獲取用戶名的ID(簡單選擇/其中查詢)返回結果運行子查詢,我可以傳入上述結果 - 獲取ID =結果的值
This sounds a lot like dynamic sql. However, there might be a better suited and appropriate way of writing this query (on Sql Server 2k5).
這聽起來很像動態sql。但是,可能有更適合和適當的方式來編寫此查詢(在Sql Server 2k5上)。
How can I go about doing this and what gotchas lurk?
EDIT: I will try something along the lines of http://www.sqlteam.com/article/introduction-to-dynamic-sql-part-1
EDIT: Thanks for the tips everyone, I wrote this:
SELECT Discount.DiscountAmount FROM Discount INNER JOIN aspnet_Users ON Discount.DiscountCode = aspnet_Users.UserId And aspnet_Users.Username = 's'
SELECT Discount.DiscountAmount FROM Discount INNER JOIN aspnet_Users ON Discount.DiscountCode = aspnet_Users.UserId and aspnet_Users.Username ='s'
Where 's' is to be replaced by a parameter.
Right, i just would do this:
SELECT * FROM TableB JOIN Users ON Users.Id = TableB.ID WHERE Users.Username = @Username
You don't have to use dynamic SQL for that.
You can use a lookup instead:
DECLARE @ID bigint SELECT @ID = ID FROM Users WHERE Username = @Username SELECT * FROM TableB WHERE ID = @ID
Then, you could add the PARAMETER @Username to your SqlCommand object, preventing the risks of SQL Injection.
Also, doing the lookup is preferable to a join, since the index is scanned a single time, for TableB.
Regarding lookup vs joins - while it may seem more intuitive for the novice to use the lookup, you should go with a join. A lookup needs to be evaluated for every row in your primary result set, while a join is evaluated once. Joins are much more efficient, which means that they are faster.
關於查找與連接 - 雖然新手使用查找似乎更直觀,但您應該使用連接。需要為主結果集中的每一行評估查找,而連接評估一次。連接效率更高,這意味着它們更快。
This is just a simple join isn't it?
SELECT x.* FROM user_table u INNER JOIN other_table x ON u.id = x.user_id WHERE u.name = @user_name
SELECT values.value FROM form_users, values WHERE form_users.username = 'John Doe' AND values.user = form_users.userid
SELECT * FROM table2 t2 JOIN UserS t1 ON t2.IDKey = t1.IDKey WHERE UserS.Username = @Input